pkg/overlay: cleanups #5927
Merged
pkg/overlay: cleanups #5927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/cleanup
nalind
added
the
No New Tests
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change generateOverlayStructure() to not return its first argument unchanged, since both of its callers already have that value, and adjust a few error messages. In the Linux MountWithOptions(), ensure that, if UpperDirOptionFragment and WorkDirOptionFragment values were specified, they are absolute paths, otherwise place them under the top-level parent of the various directories we have for this mount. Update a number of comments. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
overlay-cleanups
branch
from
fbbb309 to
670a7be
Compare
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Change
generateOverlayStructure()to not return its first argument unchanged, since both of its callers already have that value, and adjust a few error messages.In the Linux
MountWithOptions(), ensure that, ifUpperDirOptionFragmentandWorkDirOptionFragmentvalues were specified, they are absolute paths, otherwise place them under the top-level parent of the various directories we have for this mount.Update a number of comments.
How to verify it
No functional changes.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
I had so much trouble understanding how to use this package, maybe this will make it easier for the next person, who might be me.
Does this PR introduce a user-facing change?