Skip to content

[skip-ci] RPM: cleanup changelog conditionals #5888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Dec 24, 2024

rpmautospec is now supported on all active Fedora and CentOS Stream envs. So we don't need these conditionals anymore.

What type of PR is this?

/kind other

What this PR does / why we need it:

rpm spec file cleanup

How to verify it

rpmlint won't complain

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

rpmautospec is now supported on all active Fedora and CentOS Stream
envs. So we don't need these conditionals anymore.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@nalind
Copy link
Member

nalind commented Jan 7, 2025

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 676e588 into containers:main Jan 7, 2025
32 checks passed
@lsm5 lsm5 deleted the rpm-changelog-cleanup branch February 4, 2025 13:26
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants