Skip to content

refactor(changelog): removes unused code #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bhelgs
Copy link
Contributor

@bhelgs bhelgs commented Aug 2, 2022

Description

duplicate code exists in changelog_parser.py.
This bit of code seemed to be unused/untested and contributing to lower overall code coverage.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #541 (ed636ba) into master (53c66f6) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   98.01%   98.26%   +0.24%     
==========================================
  Files          39       39              
  Lines        1563     1556       -7     
==========================================
- Hits         1532     1529       -3     
+ Misses         31       27       -4     
Flag Coverage Δ
unittests 98.26% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/changelog.py 99.43% <ø> (+2.16%) ⬆️
commitizen/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362ec36...ed636ba. Read the comment docs.

@Lee-W Lee-W requested a review from woile August 2, 2022 15:45
@woile woile merged commit d36abf5 into commitizen-tools:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants