-
-
Notifications
You must be signed in to change notification settings - Fork 282
Feat/addional config ch #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/addional config ch #442
Conversation
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 98.05% 98.08% +0.02%
==========================================
Files 39 39
Lines 1441 1511 +70
==========================================
+ Hits 1413 1482 +69
- Misses 28 29 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes look good. Thanks for your contribution! Could you please add a test case to demonstrate how this affects changelog generation? Thanks!
Hi @Lee-W, thank you for taking the time to look at this! |
@woile I'll rebase and fix the conflicts if you're good with this feature. Thanks! |
I'm ok with it, go ahead |
…rn, change_type_map
…ttern, change_type_map
…attern, change_type_map customizable fields
…h customize commits
…of-line fixer exclude
1a7ed8d
to
58dac7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adding commit_parser, changelog_pattern, change_type_map as customizable fields in customize.py
I noticed that when customizing the tool, the changelog was not properly created, given the impossibility to specify a commit_parser. While adding the feature, I also added the possibility to specify a regex for changelog_pattern and the mapping contained in change_type_map.
Checklist
./script/format
and./script/test
locally to ensure this change passes linter check and testExpected behavior
When creating a changelog with a user-defined regex, the changelog should have the correct entries.
Steps to Test This Pull Request