feat: show when workspace apps are loading #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ethanndickson
requested review from
Copilot and
deansheather
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a loading indicator for workspace apps and replaces all instances of ProgressView with the new CircularProgressView.
- Adds
loadingAppsstate and displays a circular spinner while apps load - Swaps out
ProgressViewin multiple views forCircularProgressViewwith custom sizing - Ensures the spinner is hidden once loading completes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Views/VPN/WorkspaceAppIcon.swift | Replaced small ProgressView with circular spinner |
| Views/VPN/VPNMenuItem.swift | Added loadingApps flag and conditional spinner |
| Views/FileSync/FileSyncSessionModal.swift | Replaced modal ProgressView with circular spinner |
| Views/FileSync/FilePicker.swift | Replaced file-tree ProgressView with circular spinner |
Views/FileSync/FilePicker.swift (in FilePickerEntry) |
Replaced entry loader ProgressView with circular spinner |
deansheather
approved these changes
May 21, 2025
ethanndickson
force-pushed
the
ethan/workspace-apps-loading
branch
from
06b1ca3 to
8b30a75
Compare
Merge activity
|
ethanndickson
changed the base branch from
ethan/xpc-progress
to
graphite-base/163
ethan/workspace-apps-loading
ethanndickson
force-pushed
the
ethan/workspace-apps-loading
branch
from
8b30a75 to
a820d5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switches all the stock ProgressViews to our new CircularProgressView
inaction.mov
mocked.mov