chore: set 'stop VPN on quit' setting to true by default #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
commented
May 8, 2025
| guard object(forKey: key) != nil else { | ||
| return nil | ||
| } | ||
| return bool(forKey: key) |
There was a problem hiding this comment.
I don't understand why this API doesn't already just return a Bool?. It is quite silly.
There was a problem hiding this comment.
I'm also not the first to do this...
ibetitsmike
approved these changes
May 14, 2025
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fair to assume if you're closing Coder Desktop, you want Coder Connect to stop, so this is the default behaviour.
Tailscale also stops their VPN when quitting the app, even though it works fine with the app closed.
This won't have any effect on existing installations, this only sets the default value for new installations.