Skip to content

fix: output lost after hotswapping #5346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

code-asher
Copy link
Member

I think the pipe was closing the other streams when the child stream
closed so instead just write it one way.

This was making it quite difficult to debug code-server when doing live
edits in Coder.

I think the pipe was closing the other streams when the child stream
closed so instead just write it one way.
@code-asher code-asher requested a review from a team July 15, 2022 17:27
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those intricate pieces of the codebase where I'm really happy you know what's going wrong and how to fix 😂 Thanks for doing this!

@jsjoeio jsjoeio added this to the 4.5.1 milestone Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #5346 (30fb404) into main (714257b) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5346      +/-   ##
==========================================
- Coverage   72.47%   72.38%   -0.09%     
==========================================
  Files          30       30              
  Lines        1671     1673       +2     
  Branches      367      367              
==========================================
  Hits         1211     1211              
- Misses        397      399       +2     
  Partials       63       63              
Impacted Files Coverage Δ
src/node/wrapper.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714257b...30fb404. Read the comment docs.

@code-asher code-asher enabled auto-merge (squash) July 15, 2022 18:08
@code-asher code-asher merged commit 646f243 into coder:main Jul 15, 2022
@code-asher code-asher deleted the fix-hotswap-output branch December 5, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants