Skip to content

Add OpenRC support #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 9, 2022
Merged

Add OpenRC support #5266

merged 7 commits into from
Aug 9, 2022

Conversation

akr2002
Copy link
Contributor

@akr2002 akr2002 commented Jun 14, 2022

Address #5265

@akr2002 akr2002 requested a review from a team June 14, 2022 11:59
@akr2002
Copy link
Contributor Author

akr2002 commented Jun 14, 2022

I think we should have the script as a separate file instead of putting it in the markdown file. That way the user can simply use wget to download the script instead of copy-pasting the stuff.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 15, 2022

This is out of my wheelhouse. cc @oxy or @code-asher any thoughts?

My preference would be to not make this a new docs file and instead put it under https://github.com/coder/code-server/blob/main/docs/install.md as it's own section. I also wouldn't be in favor of adding a new script because then we'd have to maintain the docs and the script.

@code-asher
Copy link
Member

Maybe we can take the same path we do with the Helm stuff and delegate maintenance and testing of this to others.

If we are cool with that then splitting out the script to make life easier for users sounds chill to me.

I also like the idea of keeping it all in install.md. Out of scope for this PR but I think we might want to move some other files into there as well like android.md, ios.md, termux.md, and npm.md? Maybe even helm.md.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 16, 2022

Maybe we can take the same path we do with the Helm stuff and delegate maintenance and testing of this to others.
If we are cool with that then splitting out the script to make life easier for users sounds chill to me.

Cool! @GNUxeava you can add a script. Would you be okay reviewing any PRs that touch the docs/code you add? We'd make you a CODEOWNER?

@akr2002
Copy link
Contributor Author

akr2002 commented Jun 17, 2022

Fine by me

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 17, 2022

Sweet! @GNUxeava okay to get this in, I think we need to:

  • move this section to install.md
  • move bash script into it's own script under /ci/dev (right? @code-asher)
  • add yourself as under CODEOWNERS and point to new script

@akr2002
Copy link
Contributor Author

akr2002 commented Jun 17, 2022

I squashed some commits; hopefully it didn't break anything

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 17, 2022

Weird...it says there is an error since you don't have write access 🤔

image

I think this is fine for now. We can always edit later if needed.

@jsjoeio jsjoeio added this to the June 2022 milestone Jun 17, 2022
@jsjoeio jsjoeio modified the milestones: June 2022, July 2022 Jun 28, 2022
@jsjoeio jsjoeio self-assigned this Aug 8, 2022
@code-asher code-asher assigned code-asher and unassigned jsjoeio Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #5266 (2ca1065) into main (eb314ff) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5266      +/-   ##
==========================================
- Coverage   72.47%   72.42%   -0.05%     
==========================================
  Files          30       30              
  Lines        1671     1672       +1     
  Branches      367      366       -1     
==========================================
  Hits         1211     1211              
- Misses        397      398       +1     
  Partials       63       63              
Impacted Files Coverage Δ
src/node/wrapper.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb314ff...2ca1065. Read the comment docs.

@code-asher code-asher merged commit 7bb35af into coder:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants