-
Notifications
You must be signed in to change notification settings - Fork 6k
Add OpenRC support #5266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenRC support #5266
Conversation
I think we should have the script as a separate file instead of putting it in the markdown file. That way the user can simply use wget to download the script instead of copy-pasting the stuff. |
This is out of my wheelhouse. cc @oxy or @code-asher any thoughts? My preference would be to not make this a new docs file and instead put it under https://github.com/coder/code-server/blob/main/docs/install.md as it's own section. I also wouldn't be in favor of adding a new script because then we'd have to maintain the docs and the script. |
Maybe we can take the same path we do with the Helm stuff and delegate maintenance and testing of this to others. If we are cool with that then splitting out the script to make life easier for users sounds chill to me. I also like the idea of keeping it all in |
Cool! @GNUxeava you can add a script. Would you be okay reviewing any PRs that touch the docs/code you add? We'd make you a |
Fine by me |
Sweet! @GNUxeava okay to get this in, I think we need to:
|
I squashed some commits; hopefully it didn't break anything |
Codecov Report
@@ Coverage Diff @@
## main #5266 +/- ##
==========================================
- Coverage 72.47% 72.42% -0.05%
==========================================
Files 30 30
Lines 1671 1672 +1
Branches 367 366 -1
==========================================
Hits 1211 1211
- Misses 397 398 +1
Partials 63 63
Continue to review full report at Codecov.
|
Address #5265