-
Notifications
You must be signed in to change notification settings - Fork 6k
chore(deps): update debian docker tag to v11 #3999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3999 +/- ##
=======================================
Coverage 63.51% 63.51%
=======================================
Files 36 36
Lines 1872 1872
Branches 379 379
=======================================
Hits 1189 1189
Misses 580 580
Partials 103 103 Continue to review full report at Codecov.
|
✨ Coder.com for PR #3999 deployed! It will be updated on every commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there are any reasons why we shouldn't do this.
cc @code-asher - is this okay to approve and merge?
I don't know what this image is used for, but if it's used to build our release binaries, then it might affect our minimum glibc version requirement (the same reason that Akash pinned things to ubuntu-16.04), which in turn affects the OSes that the release binaries can be used on. I don't have any specific recommendations here though. I don't know the minimum compatibility we need |
Ahhh okay. Good to know! I'll see what @code-asher thinks then.
Maybe that's something we need to define |
We should be safe to update this; this is the end-user
`codercom/code-server` image we push to Docker Hub and it's not used in
the build process.
For this image we just copy in the .deb built by the other containers
(Centos 7 and Ubuntu 16.04 for AMD and ARM respectively).
|
Cool! Thanks for confirming! I'm going to merge |
This PR contains the following updates:
10
->11
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.