Skip to content

Add file and directory upload feature #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xuanyuanaosheng opened this issue Mar 6, 2019 · 9 comments
Closed

Add file and directory upload feature #31

xuanyuanaosheng opened this issue Mar 6, 2019 · 9 comments
Labels
enhancement Some improvement that isn't a feature

Comments

@xuanyuanaosheng
Copy link

No description provided.

@nhooyr
Copy link
Contributor

nhooyr commented Mar 6, 2019

You can use scp to do this easily. We can definitely add a UI for scp though.

@xuanyuanaosheng
Copy link
Author

You can use scp to do this easily. We can definitely add a UI for scp though.

Well。 Use scp command is not a good way for windows. The UI scp is a good way. The other way is to use plugin solve this. Please think about this:

https://github.com/liximomo/vscode-sftp

https://marketplace.visualstudio.com/items?itemName=Kelvin.vscode-sshfs

https://marketplace.visualstudio.com/items?itemName=mkloubert.vscode-remote-workspace

@PhilsLab
Copy link

PhilsLab commented Mar 8, 2019

Nextcloud has a nice way of handling this. You can just drag&drop the folder in place, and it uploads accordingly. A seperate "upload file here" button would also be nice.

Not sure if this is the right issue to address this, but i'd also like to see a download button for individual files, as well as folders/the project as zip.

@kylecarbs
Copy link
Member

I believe we have this 🤔

cc: @coderasher

@nhooyr nhooyr added enhancement Some improvement that isn't a feature needs-decision labels Mar 8, 2019
@code-asher
Copy link
Member

We do support drag and drop for uploading both files and directories.

You can drag into the main area of the editor (which will upload to the workspace root) or into the file tree (which will upload into whatever directory you dropped it on).

I think adding a button (and command) for uploading would be a good move, especially to make it more accessible from the keyboard.

We don't support downloading directories and files through the UI yet, but we want to eventually.

@jgbradley1
Copy link

jgbradley1 commented Mar 12, 2019

The Theia project recently implemented this exact same issue in case you want to check out their implementation.

@kylecarbs
Copy link
Member

Closing in favor of #233

code-asher pushed a commit that referenced this issue Jun 19, 2019
* Fix loading within the CLI

* Remove app

* Remove promise handle

* Add initial travis file

* Add libxkbfile dependency

* Add libxkbfile-dev

* Add build script

* Fix malformed bash statement

* Remove yarn from script

* Improve build script

* Extract upx before usage

* Only run upx if on linux

* Ensure resource directory exists

* Pack runnable binary

* Export binary with platform

* Improve build process

* Install upx before running install script

* Update typescript version before running nexe

* Add os.release() function for multi-platform support

* Update travis.yml to improve deployment

* Add on CI

* Update to v1.31.0

* Add libsecret

* Update build target

* Skip cleanup

* Fix built-in extensions

* Add basics for apps

* Create custom DNS server

* Fix forking within CLI. Fixes TS language features

* Fix filename resolve

* Fix default extensions path

* Add custom dialog

* Store workspace path

* Remove outfiles

* Cleanup

* Always authed outside of CLI

* Use location.host for client

* Remove useless app interface

* Remove debug file for building wordlist

* Use chromes tcp host

* Update patch

* Build browser app before packaging

* Replace all css containing file:// URLs, fix webviews

* Fix save

* Fix mkdir
@achirkin
Copy link

I am sorry to resurrect this discussion, but it looks like the upload feature is not cross-platform.
I am hosting code-server on linux;

  • Drag-n-drop on a linux machine works like a charm
  • On chrome OS it says "Cannot read property 'isFile' of null"
  • On windows it tries to copy a file into a path with backslashes instead of normal slashes. I get something like "Cannot copy '/\home\username\bluh-bluh': access denied"

@sr229
Copy link
Contributor

sr229 commented Dec 21, 2019

Please bring this up on #233. I'll be locking this thread.

@coder coder locked as resolved and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

7 participants