Skip to content

Use _id when unmarshalling team members API response #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kierang-contino
Copy link
Contributor

@kierang-contino kierang-contino commented Oct 17, 2022

What

Use _id when unmarshalling the API response for team members

Why

Recent versions of the codefresh API do not return id for team members, only _id. See #93 for more details

Notes

Closes #93

@lrochette lrochette requested a review from korenyoni October 17, 2022 14:42
@korenyoni korenyoni added the bug Something isn't working label Oct 18, 2022
Copy link
Contributor

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution!

@korenyoni korenyoni merged commit 22bf53a into codefresh-io:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest API returns only _id for team members
2 participants