fix: propagation of attributes mode, fail_fast, and hooks from originalYamlString #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrogattuso
changed the title
sandrogattuso
force-pushed
the
bugfix/originalYamlStringModeAndFailFast
branch
from
515053e to
03cd76e
Compare
alex-codefresh
approved these changes
Apr 22, 2021
| case "mode": | ||
| pipeline.Spec.Mode = item.Value.(string) | ||
| case "fail_fast": | ||
| pipeline.Spec.FailFast = item.Value.(bool) |
There was a problem hiding this comment.
In case if "fail_fast" is false, it will not be propagated to the pipeline spec, because the JSON marshaller will interpret "false" as "empty" and omit it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added business logic to propagate attributes
mode,fail_fast, andhooksto theSpecsection when using theoriginalYamlStringsetup.