Skip to content

Support for shared configuration in pipelines #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sandrogattuso
Copy link
Contributor

This change should allow to set contexts in a pipeline resource. I've compiled a version of the provider from my branch and tested it with a secret context and a config context. The pipeline created loads correctly the contexts.

I've updated the test files, however, I couldn't get the test working locally since I'm getting this error (NOTE: I get the below even from master branch without any change, so this is not related to the changes introduced in this PR):

 testing_new.go:106: terraform failed: exit status 1
        stderr:
        Error: Failed to instantiate provider "codefresh" to obtain schema: Unrecognized remote plugin message: 

I'm happy to perform further validations and have the test cases validated on my end, but I might need some guidance on how to resolve the above.

Closes #15

@palson-cf
Copy link
Contributor

@sandrogattuso
Thanks a lot for contributing.

I've tested your changes and everything seems working.

Regarding testing - you're right. Tests didn't work.
It would be better to divide contexts and tests on two separate PRs. But let leave it as is.
I found a few broken tests as well. Will fix them after your merge.

Please add the new context attribute to the pipelines docs and I will merge your changes.

@sandrogattuso
Copy link
Contributor Author

@palson-cf updated the pipeline.md and pipelines.md (in examples folder). Let me know if I've missed anything else or if you want me to squash commits (not sure what's the guideline on this repo in that regard)

@palson-cf palson-cf merged commit 5bc995c into codefresh-io:master Nov 24, 2020
@sandrogattuso sandrogattuso deleted the feature/shared-configurations branch December 17, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support setting (shared configuration) contexts in the pipeline resource
2 participants