You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When you try to modify the cron trigger from terraform, it creates a new trigger with the new settings but doesn't delete the old one.
Details:
Add a cron trigger and try to update it:
Terraform will perform the following actions:
# codefresh_pipeline_cron_trigger.test will be updated in-place~ resource "codefresh_pipeline_cron_trigger""test" {
~ expression = "*/1 * * * 1" ->"*/1 * * * 2"
id = "cron:codefresh:*/1 * * * 1:Example Cron Trigger:53be2183993e"# (2 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Apply:
Plan: 0 to add, 1 to change, 0 to destroy.
Do you want to perform these actions?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.
Enter a value: yes
codefresh_pipeline_cron_trigger.test: Modifying... [id=cron:codefresh:*/1 *** 1:Example Cron Trigger:53be2183993e]
codefresh_pipeline_cron_trigger.test: Modifications complete after 1s [id=cron:codefresh:*/1 *** 2:Example Cron Trigger:53be2183993e]
Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
Two cron triggers now exist in the pipeline:
Expected Behavior:
Cron trigger object modified
Current behavior:
A new cron trigger is created, but the old one isn’t deleted.
The text was updated successfully, but these errors were encountered:
…igger Testing (#100)
## What
* Add Cron Trigger plan-time validation
* Fix Cron Trigger updating (force replacement of resource on any
change, because there is no update verb in the cron trigger API)
* Improve Cron Trigger Testing
* Misc: remove use of "Hermes" service name in Provider logs. While
accurate in the [API
docs](https://g.codefresh.io/api/#tag/Triggers-Events), this may cause
unnecessary confusion to users of the Terraform provider.
## Why
* Updating a Cron Trigger results in duplicates
* No plan-time validation on Cron Triggers
## Notes
* Closes#99
* Closes#98
* Adding a `minor` label because now we have plan-validation, which can
potentially break existing cron trigger configurations in Terraform)
Co-authored-by: Yonatan Koren <[email protected]>
When you try to modify the cron trigger from terraform, it creates a new trigger with the new settings but doesn't delete the old one.
Details:
Add a cron trigger and try to update it:
Apply:
Two cron triggers now exist in the pipeline:
Expected Behavior:
Cron trigger object modified
Current behavior:
A new cron trigger is created, but the old one isn’t deleted.
The text was updated successfully, but these errors were encountered: