Skip to content

feat: removal of event-reporter from cf argo-cd fork #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 7, 2025
6 changes: 3 additions & 3 deletions charts/gitops-runtime/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
appVersion: 0.1.69-0
appVersion: 0.1.71
description: A Helm chart for Codefresh gitops runtime
name: gitops-runtime
version: 0.0.0
Expand All @@ -17,7 +17,7 @@ dependencies:
- name: argo-cd
repository: https://codefresh-io.github.io/argo-helm
condition: argo-cd.enabled
version: 7.8.23-2-cap-v2.14.9-2025-04-23-4de04dd8
version: 7.8.23-3-cap-v2.14.9-2025-04-23-4de04dd8
- name: argo-events
repository: https://codefresh-io.github.io/argo-helm
version: 2.4.7-1-cap-CR-28072
Expand Down Expand Up @@ -49,4 +49,4 @@ dependencies:
condition: garage-workflows-artifact-storage.enabled
- name: cf-argocd-extras
repository: oci://quay.io/codefresh/charts
version: 0.3.17
version: 0.3.20
9 changes: 3 additions & 6 deletions charts/gitops-runtime/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,14 @@ sealed-secrets:
| app-proxy.image-enrichment.serviceAccount.name | string | `"codefresh-image-enrichment-sa"` | Name of the service account to create or the name of the existing one to use |
| app-proxy.image.pullPolicy | string | `"IfNotPresent"` | |
| app-proxy.image.repository | string | `"quay.io/codefresh/cap-app-proxy"` | |
| app-proxy.image.tag | string | `"1.3389.0"` | |
| app-proxy.image.tag | string | `"1.3451.0"` | |
| app-proxy.imagePullSecrets | list | `[]` | |
| app-proxy.initContainer.command[0] | string | `"./init.sh"` | |
| app-proxy.initContainer.env | object | `{}` | |
| app-proxy.initContainer.extraVolumeMounts | list | `[]` | Extra volume mounts for init container |
| app-proxy.initContainer.image.pullPolicy | string | `"IfNotPresent"` | |
| app-proxy.initContainer.image.repository | string | `"quay.io/codefresh/cap-app-proxy-init"` | |
| app-proxy.initContainer.image.tag | string | `"1.3389.0"` | |
| app-proxy.initContainer.image.tag | string | `"1.3451.0"` | |
| app-proxy.initContainer.resources.limits | object | `{}` | |
| app-proxy.initContainer.resources.requests.cpu | string | `"0.2"` | |
| app-proxy.initContainer.resources.requests.memory | string | `"256Mi"` | |
Expand Down Expand Up @@ -244,9 +244,6 @@ sealed-secrets:
| argo-cd.configs.params."server.insecure" | bool | `true` | |
| argo-cd.crds.install | bool | `true` | |
| argo-cd.enabled | bool | `true` | |
| argo-cd.eventReporter.enabled | bool | `true` | Installs new event reporter component to cluster |
| argo-cd.eventReporter.replicas | int | `3` | Amount of shards to handle applications events |
| argo-cd.eventReporter.version | string | `"v2"` | Switches between old and new reporter version. Possible values: v1, v2. For v2 `argo-cd.eventReporter.enabled=true` is required |
| argo-cd.fullnameOverride | string | `"argo-cd"` | |
| argo-events.configs.jetstream.versions[0].configReloaderImage | string | `"natsio/nats-server-config-reloader:0.16.0"` | |
| argo-events.configs.jetstream.versions[0].metricsExporterImage | string | `"natsio/prometheus-nats-exporter:0.15.0"` | |
Expand Down Expand Up @@ -327,7 +324,7 @@ sealed-secrets:
| gitops-operator.crds.install | bool | `true` | Whether or not to install CRDs |
| gitops-operator.crds.keep | bool | `false` | Keep CRDs if gitops runtime release is uninstalled |
| gitops-operator.enabled | bool | `true` | |
| gitops-operator.env | object | `{}` | |
| gitops-operator.env.TASK_PULLING_INTERVAL | string | `"10s"` | |
| gitops-operator.fullnameOverride | string | `""` | |
| gitops-operator.image | object | `{}` | |
| gitops-operator.imagePullSecrets | list | `[]` | |
Expand Down
4 changes: 2 additions & 2 deletions charts/gitops-runtime/templates/event-reporter.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- $cfArgoCdExtrasContext := (index .Subcharts "cf-argocd-extras")}}
{{- if not (index .Values "argo-cd" "enabled") }}
{{- $cfArgoCdExtrasContext := (index .Subcharts "cf-argocd-extras")}}

{{- $_ := set (index $cfArgoCdExtrasContext.Values.eventReporter.configMaps "cmd-params-cm" "data") "argocd.server" (include "codefresh-gitops-runtime.argocd.server.no-protocol-url" . ) }}
{{- $_ := set (index $cfArgoCdExtrasContext.Values.eventReporter.configMaps "cmd-params-cm" "data") "redis.server" (include "codefresh-gitops-runtime.argocd.redis.url" . ) }}
Expand All @@ -19,5 +19,5 @@
{{- $_ := set $cfArgoCdExtrasContext.Values.eventReporter.container.env "ARGOCD_SERVER_ROOTPATH" (index .Values "global" "external-argo-cd" "server" "rootpath") }}
{{- end }}

{{- include "cf-argocd-extras.event-reporter.resources" $cfArgoCdExtrasContext }}
{{- end }}
{{ include "cf-argocd-extras.event-reporter.resources" $cfArgoCdExtrasContext }}
17 changes: 15 additions & 2 deletions charts/gitops-runtime/tests/cf-argocd-extras_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ tests:
app.kubernetes.io/instance: RELEASE-NAME
app.kubernetes.io/component: sources-server

- it: New Event-Reporter should NOT be deployed with forked ArgoCD
- it: New Event-Reporter should be deployed with forked ArgoCD
template: event-reporter.yaml
values:
- ./values/mandatory-values-ingress.yaml
Expand All @@ -67,7 +67,20 @@ tests:
kind: StatefulSet
apiVersion: apps/v1
name: event-reporter
not: true
documentIndex: 4

- it: New Event-Reporter should be deployed with forked ArgoCD even if it's disabled in extras values
template: event-reporter.yaml
values:
- ./values/mandatory-values-ingress.yaml
set:
cf-argocd-extras.eventReporter.enabled: false
asserts:
- containsDocument:
kind: StatefulSet
apiVersion: apps/v1
name: event-reporter
documentIndex: 4

- it: New Event-Reporter should be deployed with external OSS ArgoCD
template: event-reporter.yaml
Expand Down
25 changes: 25 additions & 0 deletions charts/gitops-runtime/tests/forked-argocd_test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
suite: forked argo-cd tests
templates:
- charts/argo-cd/*
tests:
- it: Should not have argo-cd-event-reporter in forked argo-cd
values:
- ./values/mandatory-values-ingress.yaml
asserts:
- containsDocument:
kind: StatefulSet
apiVersion: apps/v1
name: argo-cd-event-reporter
not: true
- it: Should not have argo-cd-event-reporter in forked argo-cd even when it has old values
values:
- ./values/mandatory-values-ingress.yaml
set:
argo-cd.eventReporter.enabled: true
argo-cd.eventReporter.replicas: 2
asserts:
- containsDocument:
kind: StatefulSet
apiVersion: apps/v1
name: argo-cd-event-reporter
not: true
13 changes: 0 additions & 13 deletions charts/gitops-runtime/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -248,16 +248,6 @@ argo-cd:
server.insecure: true
application.namespaces: 'cf-*'

eventReporter:
# -- Installs new event reporter component to cluster
enabled: true
# -- Amount of shards to handle applications events
replicas: 3
# -- Switches between old and new reporter version.
# Possible values: v1, v2.
# For v2 `argo-cd.eventReporter.enabled=true` is required
version: v2

applicationVersioning:
# -- Enable application versioning
enabled: true
Expand Down Expand Up @@ -745,6 +735,3 @@ garage-workflows-artifact-storage:
cf-argocd-extras:
# -- Library mode for the chart. Allows to inject values from gitops runtime chart
libraryMode: true
# -- Event reporter configuration
eventReporter:
enabled: true