feat: limits enforcement in runtime installation #457
Merged
+98
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # installer-image/Dockerfile
charts/gitops-runtime/templates/hooks/pre-install/validate-usage.yaml
Outdated
Show resolved
Hide resolved
charts/gitops-runtime/templates/hooks/pre-install/validate-usage.yaml
Outdated
Show resolved
Hide resolved
charts/gitops-runtime/templates/hooks/pre-install/validate-usage.yaml
Outdated
Show resolved
Hide resolved
denis-codefresh
approved these changes
Apr 23, 2025
dmaizel
approved these changes
Apr 24, 2025
dmaizel
changed the title
|
/e2e |
1 similar comment
|
/e2e |
|
/e2e |
|
/e2e |
|
/e2e |
1 similar comment
|
/e2e |
mikhail-klimko
approved these changes
May 7, 2025
|
/e2e |
andrii-codefresh
added a commit
that referenced
this pull request
May 14, 2025
This reverts commit c26b05c
ilia-medvedev-codefresh
pushed a commit
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A pre-install hook with the ability to be disabled
Why
Prevents runtime installation if clusters limit is reached.
The final validation will take place during the runtime registration on the platform.
This hook allows us to stop the installation at an early stage.
It's not a reliable mechanism, just an additional one to save time and resources.
Notes
This PR was recreated with new branch name from this one:
#452