feat: update setup URL in NOTES.txt to use dynamic values #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-klimko
approved these changes
Apr 15, 2025
plakyda-codefresh
changed the title
|
/e2e |
ilia-medvedev-codefresh
pushed a commit
that referenced
this pull request
May 14, 2025
* fix: update setup URL in NOTES.txt to use dynamic values * fix: correct formatting in setup URL in NOTES.txt * fix: update conditional check for argo-cd in NOTES.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the GitOps Runtime installation completion URL to open a specific drawer instead of just the runtime list, and it includes additional parameters to manage the installation flow.
Notes
Drawer opened: The URL now opens the "install-runtime-wizard" drawer instead of the runtime list.
Waiting for events: The waitEvents=true parameter is added to signal that the process should wait for the runtime events to be completed.
Dynamic URL: The URL dynamically includes:
{{ .Values.global.codefresh.url }} – The base URL for the Codefresh platform.
{{ .Values.global.codefresh.accountId }} – The account ID for user-specific routing.
{{ .Values.global.runtime.name }} – The name of the runtime being installed.
Conditional installation mode: Based on whether argo-cd is enabled or not, the installation mode is adjusted:
If argo-cd is enabled: mode=new
Otherwise: mode=byoa