Skip to content

Issue 48 - Add custom assert message #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Issue 48 - Add custom assert message #64

merged 2 commits into from
Apr 29, 2020

Conversation

jonatask
Copy link
Contributor

Closes issue #48

@puneet0191
Copy link
Member

@jonatask I am not sure, how this allows adding custom msg?

@jonatask
Copy link
Contributor Author

@puneet0191 It improves the displayed message in the test report.
Beyond the mismatch percentage, now the message also says which is the baseline it compared against.

@puneet0191 puneet0191 changed the base branch from master to 1.9.1 April 28, 2020 06:27
@puneet0191
Copy link
Member

@jonatask thanks for the clarification, but issue #48 talks about custom assert message or ability to pass such message as parameter.

Also could you please fix merge conflict so I could merge it to 1.9.1 and prepare for release

@jonatask
Copy link
Contributor Author

jonatask commented Apr 28, 2020

@puneet0191 The conflict has been solved.

@puneet0191 puneet0191 merged commit c5d70b9 into codeceptjs:1.9.1 Apr 29, 2020
@jonatask jonatask deleted the issue-48-add-custom-assert-message branch May 2, 2020 09:51
puneet0191 added a commit that referenced this pull request May 16, 2020
* Issue #60 - Prepare all baselines of test by setting parameter in config (#65)

Co-authored-by: Jonatas Kirsch <[email protected]>

* Update Dependecies, Fix Fatal Error with mkdirp and Mac (#66)

* Update Dependencies

* Fix Error on Mac

* Avoid failing the test for a given threshold but yet generating the difference image (#63)

* Option bypassFailure allowing the user to avoid failing the test for a given threshold but yet generating the difference image

* Renamed option to skipFailure

Co-authored-by: Jonatas Kirsch <[email protected]>

* feat(testcafe): add the support for testcafe (#62)

* passing through output settings to resemble.js (#59)

Co-authored-by: JANK Michael <[email protected]>

* Issue 48 - Add custom assert message (#64)

Co-authored-by: Jonatas Kirsch <[email protected]>

Co-authored-by: Jonatas Kirsch <[email protected]>
Co-authored-by: Jonatas Kirsch <[email protected]>
Co-authored-by: Guillaume Camus <[email protected]>
Co-authored-by: yankydoo <[email protected]>
Co-authored-by: JANK Michael <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants