Skip to content

Avoid crash on size mismatch #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2019
Merged

Avoid crash on size mismatch #43

merged 2 commits into from
Aug 21, 2019

Conversation

tairun
Copy link
Contributor

@tairun tairun commented Aug 15, 2019

Fixes #41

@puneet0191 puneet0191 merged commit 5181f41 into codeceptjs:master Aug 21, 2019
@gtycherry
Copy link

Hi @tairun
I ran into crash issue with the same error you mentioned in #41 . Below is the error I ran into:

image

Node:10.20.1
codeceptjs: ^2.6.5
codeceptjs-resemblehelper: 1.9.0

Could you please help to give some suggestion on this issue? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneet0191 puneet0191 puneet0191 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node crash if dimension mismatch in I.seeVisualDiff
3 participants
@tairun @gtycherry @puneet0191