Update index allure report support.js #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrating allure report.
puneet0191
requested changes
Mar 25, 2019
puneet0191
requested changes
Mar 25, 2019
index.js
Outdated
| { | ||
| const allureReporter = Container.plugins('allure'); | ||
| if (allureReporter) { | ||
| allureReporter.addAttachment('Screenshot diffImage', fs.readFileSync(path.join(global.output_dir, fileName)), 'image/png'); |
There was a problem hiding this comment.
Use the actual Diff Image name, using Test Names
There was a problem hiding this comment.
Tried, please review it again.
puneet0191
requested changes
Mar 27, 2019
index.js
Outdated
| @@ -6,6 +6,8 @@ const fs = require('fs'); | |||
| let assert = require('assert'); | |||
| const mkdirp = require('mkdirp'); | |||
| const getDirName = require('path').dirname; | |||
| const Container = require('../container'); | |||
| const Codeceptjs = require('../index'); | |||
There was a problem hiding this comment.
Because we need container module for allure report. Updated my code again please review
There was a problem hiding this comment.
@puneet0191 updated it now please see
puneet0191
requested changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Idea about Integrating allure report.
Please review it @puneet0191