-
Notifications
You must be signed in to change notification settings - Fork 6
be more permissive by default #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change CHECK_PUPPET_DOCS
back to enable
. This should be solved at local environment.
how do you actually do this in this repo? it seems i necessarily have to fork the repo, or can we have configs not checked in? |
We solved this by a script in our control repo. Here you can modify all params by search and replace. |
isn't this the script that runs from your control repo? I think I don't understand. :) |
This are the local git hooks. To install it, we provide a script, which clone the repo and install the hooks. At this time modifications are possible. |
sorry for the multiple questions, but you basically patch the git worktree on deployment? |
The repository is intended to help developers of a control-repo to push only clean code. The nature of the hooks of this repo is that they are client-side hooks and have to be installed in
What this repo is not indended for it to use it at deployment time. Hopefully this make some things clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
interesting. this is definitely out of scope for this PR, but since you don't have issues enabled (and seem more active than the upstream), i'll dare ask more. :) i'm surprised: there are definitely server-side hooks in here: anyways, i guess i should figure out a way to load an external config file so we don't have to modify the worktree, would you be open to such a PR? |
I transferred the repo to our open source org codeaffen here. I also activate discussions, where we can discuss further. |
We stop failing on docs test by default, and avoid failing on linting warnings.
This is a matter of policy I guess, but since there's no way to modify the config short of committing to the repository, I figured I would share my own configurations. Ideally, those kind of site-local policies could be established without having to edit the worktree...