Fix typo & Fix app_id requirement and default #124
Conversation
There was a problem hiding this comment.
HI @StevenH1901,
Thank you for opening this PR, Some things need to be in place before we can merge it.
- combine all fix typo commits to a single commit
- add a test for checking the behavior of the app_id parameter, ideally for all common parameters
- extend the section test to check the list_order parameter.
|
@cmeissner - Not 100% sure if this is what you were expecting, but if not let me know and I can get it fixed. I'm also not sure how to combine two commits that have different commits between them. |
Thank you for adding/extending the requested tests. I did not find the time to run it on my system. May I ask you to enable the I will try to review your PR completely on the weekend. |
Update `app_id` to be not required and set default to ansible as per documentation.
* make tool chain work with podman too * update db setup script to work with podman * set predictable container names * fix fissues with starting docker-compose in CI * upgrade `docker-compose` before run phpipam-action * pin python to version 3.9 as long we did not found time to test newer versions run stale workflow on hosted runners
* upgrade `docker-compose` before run phpipam-action * pin python to version 3.9 as long we did not found time to test newer versions
Per the section_module docs (and all other modules), app_id is not a required parameter and should default to 'ansible'.
When running version 1.7.0, I receive an error saying that 'app_id' is a required parameter. This error may be present in previous versions, but I have not verified.
Fixes #123