-
Notifications
You must be signed in to change notification settings - Fork 16
Update grammars #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grammars #78
Conversation
7dacca0
to
5110cf5
Compare
5110cf5
to
32fd205
Compare
I see that purcell/package-lint#292 was merged and released (v0.25) and we're using the most recent version here, but it's still complaining about the version:
@bbatsov any ideas what could it be? |
I'm not sure how Eldev uses |
I've figured that package-lint v0.25 doesn't include the version bump. We need to wait for the next release. |
In general our config for Eldev seems broken, as by mistake I had set it to run only one linter, and it still seems to run all of them. Go figure! That's the relevant docs https://emacs-eldev.github.io/eldev/#linting I realized this only recently while looking at the package-lint problem. 🤦 See also emacs-eldev/eldev#113 |
Still, it'd be faster to just disable it. It's the least useful linter anyways, as it checks super basic stuff. |
I'll merge the PR as it's in a good shape. The Eldev config and the Markdown improvements can be tackled separately. |
Close #77
Some highlights:
markdown_inline
tomarkdown-inline
.markdown-ts-mode
was added to Emacs master and it expectsmarkdown-inline
grammar (https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/textmodes/markdown-ts-mode.el#n62), so I decided to makeclojure-ts-mode
aligned with Emacs master (otherwise there would be 2 markdown inline binaries)clojure-ts-reinstall-grammars
functionmarkdown-inline
feature and I couldn't reproduce memory leak. Hopefully it's fixed by updating the grammar. But I'm still observing the problem with incorrect fontification when backticks in the docstrings are unbalanced, as mentioned in Issues with markdown inline #60. I'm thinking about submitting a bug report to Emacs and get some help regarding this situation.markdown-inline
grammar, now when backticks are balanced, they are always highlighted correctly.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdoc
and fixed any warnings in the code you've written.Thanks!