-
Notifications
You must be signed in to change notification settings - Fork 16
Fix some issues with indentation for items with metadata #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bbatsov
merged 1 commit into
clojure-emacs:main
from
rrudakov:fix/indentation-with-metadata
Apr 3, 2025
Merged
Fix some issues with indentation for items with metadata #68
bbatsov
merged 1 commit into
clojure-emacs:main
from
rrudakov:fix/indentation-with-metadata
Apr 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7695b66
to
e369db9
Compare
bbatsov
reviewed
Apr 3, 2025
bbatsov
reviewed
Apr 3, 2025
bbatsov
reviewed
Apr 3, 2025
bbatsov
reviewed
Apr 3, 2025
Overall the change seem good to me. |
Thanks for the review @bbatsov. Writing docstrings is definitely not one of my strengths :) I'll fix everything shortly. |
e369db9
to
b2a2867
Compare
bbatsov
reviewed
Apr 3, 2025
…tadata - Collection elements (except of lists) are properly indented. - Body of special forms when the entire form has metadata is properly indented. - Additionally fix syntax highlighting of special forms when the entire form has metadata.
b2a2867
to
cd5c078
Compare
bbatsov
approved these changes
Apr 3, 2025
Thanks for another great PR! And sorry for the slow turnaround here! |
No problem at all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #61
Before:

Here besides incorrect indentation,

if
is not highlighted properly:After:

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdoc
and fixed any warnings in the code you've written.Thanks!