Skip to content

Improve syntax highlighting #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rrudakov
Copy link
Contributor

Fix a few issues with syntax highlighting I discovered.

Before:
image

image

image

After:
image

image

image

There were failing tests in clojure-ts-mode-font-lock-test.el (not sure how did they pass CI before), those are fixed now.


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@rrudakov rrudakov force-pushed the feature/improve-syntax-highlighting branch from 5e8a7d2 to 3ceb0a6 Compare March 22, 2025 19:59
@rrudakov
Copy link
Contributor Author

Looks like linter doesn't like ;; Package-Requires: ((emacs "30.1"))

@bbatsov
Copy link
Member

bbatsov commented Mar 24, 2025

@rrudakov I'm aware of this and I had opened purcell/package-lint#292

Overall it seems to me that aiming to support Emacs 29 doesn't make much sense due to the moving nature of the TreeSitter support, but package-lint needs to be updated for the CI to pass or we need to revert the changes dropping Emacs 29 support.

@rrudakov
Copy link
Contributor Author

@bbatsov can we maybe merge it like this and deal with the linter separately?

@bbatsov
Copy link
Member

bbatsov commented Mar 24, 2025

Yeah, the linter is not an issue at all - I was just responding to the remark about it. At a glance your changes seem fine to me, but I wanted to take a closer look.

@bbatsov bbatsov merged commit f932fc3 into clojure-emacs:main Mar 25, 2025
2 of 3 checks passed
@bbatsov
Copy link
Member

bbatsov commented Mar 25, 2025

All the changes look good to me. Thanks!

@rrudakov rrudakov deleted the feature/improve-syntax-highlighting branch March 25, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants