Skip to content

Identify basilisp.edn and .lpy file extensions as Clojure type #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

ikappaki
Copy link
Contributor

@ikappaki ikappaki commented Mar 2, 2024

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our [contribution guidelines][1].
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

I haven't added any tests yet because of the simplicity of the change and closely following the .clj paradigm, but let me know if this is of concern.

The basilisp.edn file is a project placeholder that has no other use at the moment other to provisionally indicate this is the root of a Basilisp project.

I plan to add some syntax highlighting for builtin Basilisp symbol at some later point, at the moment I'm just looking at minimal support to get it working with Cider.

Thanks

@bbatsov bbatsov merged commit 975b3a2 into clojure-emacs:master Mar 2, 2024
@bbatsov
Copy link
Member

bbatsov commented Mar 2, 2024

Thanks!

@bbatsov bbatsov mentioned this pull request Mar 4, 2024
@ikappaki
Copy link
Contributor Author

ikappaki commented Mar 4, 2024

(CI breaks are unrelated and most likely due to jorgenschaefer/emacs-buttercup#244)

@ikappaki
Copy link
Contributor Author

ikappaki commented May 25, 2024

Hi @bbatsov / @vemv,

could you please release this to melpa stable?

I plan to provide jack in support in cider and need to reference it as a dependency.

thanks

@vemv
Copy link
Member

vemv commented May 25, 2024

Hi @ikappaki ,

a stable release should be out soon enough. It's been in the works.

Probably first day of June would be a reasonable deadline for us to wrap any stuff in flight.

Cheers - V

@bbatsov
Copy link
Member

bbatsov commented May 26, 2024

Probably first day of June would be a reasonable deadline for us to wrap any stuff in flight.

@vemv Do we have anything anything in progress for clojure-mode? Looking at the changelog and the issues I don't see anything we need to tackle.

@vemv
Copy link
Member

vemv commented May 26, 2024

ah sorry, thought this was cider.

@ikappaki
Copy link
Contributor Author

thanks guys, when do you anticipate being able to make the next release?

@vemv
Copy link
Member

vemv commented May 26, 2024

Let me do it just now

@vemv
Copy link
Member

vemv commented May 26, 2024

Tagged! It will be visible on MELPA in a couple hours.

@ikappaki
Copy link
Contributor Author

Thanks @vemv,

one last thing, is the releases page still relevant? It hasn't been updated since version 5.16.

https://github.com/clojure-emacs/clojure-mode/releases

image

@vemv
Copy link
Member

vemv commented May 26, 2024

That could be just me as I don't have the habit of creating releases (except in CIDER).

tbh it's quite a bit of busy work, especially as we already have tags and changelog. Sadly it's not automatable OOTB.

https://github.com/clojure-emacs/cider-nrepl/releases also has lagged behind. Thoughts? @bbatsov

@bbatsov
Copy link
Member

bbatsov commented May 27, 2024

I always create the releases manually when I do them. It's a bit of manual work indeed, but it takes only a minute and it's useful for the users, as those appear automatically on the project homepage. I'd recommend to backfill the missing releases, as that will take only a couple of minutes.

@bbatsov
Copy link
Member

bbatsov commented May 27, 2024

I just added the missing entries for clojure-mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants