-
-
Notifications
You must be signed in to change notification settings - Fork 247
Identify basilisp.edn
and .lpy
file extensions as Clojure type
#676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! |
(CI breaks are unrelated and most likely due to jorgenschaefer/emacs-buttercup#244) |
Hi @ikappaki , a stable release should be out soon enough. It's been in the works. Probably first day of June would be a reasonable deadline for us to wrap any stuff in flight. Cheers - V |
@vemv Do we have anything anything in progress for |
ah sorry, thought this was cider. |
thanks guys, when do you anticipate being able to make the next release? |
Let me do it just now |
Tagged! It will be visible on MELPA in a couple hours. |
Thanks @vemv, one last thing, is the releases page still relevant? It hasn't been updated since version 5.16. https://github.com/clojure-emacs/clojure-mode/releases |
That could be just me as I don't have the habit of creating releases (except in CIDER). tbh it's quite a bit of busy work, especially as we already have tags and changelog. Sadly it's not automatable OOTB. https://github.com/clojure-emacs/cider-nrepl/releases also has lagged behind. Thoughts? @bbatsov |
I always create the releases manually when I do them. It's a bit of manual work indeed, but it takes only a minute and it's useful for the users, as those appear automatically on the project homepage. I'd recommend to backfill the missing releases, as that will take only a couple of minutes. |
I just added the missing entries for clojure-mode. |
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdoc
and fixed any warnings in the code you've written.I haven't added any tests yet because of the simplicity of the change and closely following the
.clj
paradigm, but let me know if this is of concern.The
basilisp.edn
file is a project placeholder that has no other use at the moment other to provisionally indicate this is the root of a Basilisp project.I plan to add some syntax highlighting for builtin Basilisp symbol at some later point, at the moment I'm just looking at minimal support to get it working with Cider.
Thanks