Skip to content

[Fix #496] Highlight [[var]] style comments #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rpkarlsson
Copy link
Contributor

@rpkarlsson rpkarlsson commented Apr 9, 2019

Highlight [[var]] style comments as suggested in #496 using the same rules as backtick-code highlighting.

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

@bbatsov
Copy link
Member

bbatsov commented Apr 9, 2019

Looks good to me, but you'll need to add also a couple of unit tests and a changelog entry.

@rpkarlsson rpkarlsson force-pushed the highlight-wikilinks-markdown-comments branch from 1b3e89d to 0a97ddb Compare April 10, 2019 19:23
@bbatsov bbatsov merged commit e2c6a4a into clojure-emacs:master Apr 13, 2019
@bbatsov
Copy link
Member

bbatsov commented Apr 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants