Fix clojure-find-ns when there's a ns form inside a string #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Mar 23, 2019
clojure-mode.el
Outdated
| (and (goto-char (point-min)) | ||
| (re-search-forward clojure-namespace-name-regex nil t))) | ||
| (match-string-no-properties 4)))))) | ||
| (let* ((ns (save-excursion |
There was a problem hiding this comment.
Seems to me a regular let would do here.
bbatsov
reviewed
Mar 24, 2019
clojure-mode.el
Outdated
| @@ -1886,6 +1886,19 @@ the cached value will be updated automatically." | |||
| (defvar-local clojure-cached-ns nil | |||
| "A buffer ns cache used to speed up ns-related operations.") | |||
|
|
|||
| (defun clojure--find-ns-in-direction (dir) | |||
There was a problem hiding this comment.
Every time I see dir I think of directory, but that's not a big deal. It's a good idea to extract this.
There was a problem hiding this comment.
No reason to be lazy anyway. Changed it to direction.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this placeholder text with a summary of the changes in your PR.
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!