[Fix #506] fix clojure-mode-display-version #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cichli
reviewed
Feb 25, 2019
…al version `clojure-mode-display-version` displays the correct version (was displaying nil) also added some tests
cichli
added a commit
to cichli/clojure-mode
that referenced
this pull request
Feb 27, 2019
[Fix clojure-emacs#506] fix clojure-mode-display-version
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lm-versionwas returning nil, since it tried to look at the buffer headers to get the version, but it couldn't during load. I gave the contents ofclojure-mode.el, in a temporary buffer to (lm-version) so it can read it.Perhaps all the contents of
clojure-mode.elshould not be copied over to the temporary buffer. Should this buffer contain only part of it (only the file headers for example) ?M-x checkdocand fixed any warnings in the code you've written.