Skip to content

Introduce clojure-align-separator defcustom #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

vemv
Copy link
Member

@vemv vemv commented Sep 2, 2018

Fixes #481

I'm not sure I used the type '(choice (const ... syntax correctly, since when I changed it using the value menu in M-x customize variable, the value of clojure-align-separator would appear unchanged (even though the widget says otherwise).

@Malabarba
Copy link
Member

Malabarba commented Sep 3, 2018

There's one quote too-many in the values of the choice spec.
The way you've defined it, the first value is the symbol clojure--align-separator-newline-regexp, and the second value is the list (quote entire).
I think you need to replace it with this:

`(choice (const :tag "Make blank lines prevent vertical alignment from happening."
                ,clojure--align-separator-newline-regexp)
         (other :tag "Allow blank lines to happen within a vertically-aligned expression."
                entire))

@vemv
Copy link
Member Author

vemv commented Sep 4, 2018

Thanks for the help! Tried out, works correctly. Commit amended.

:safe and :type values are missing because I couldn't find out the syntax for an option between symbol and regexp.

@vemv
Copy link
Member Author

vemv commented Sep 24, 2018

Status?

@bbatsov bbatsov merged commit 9127dc4 into clojure-emacs:master Sep 25, 2018
@bbatsov
Copy link
Member

bbatsov commented Sep 25, 2018

Ops, sorry about that. It completely slipped my mind. Thanks!

@vemv
Copy link
Member Author

vemv commented Sep 25, 2018

Thanks to you!

I noticed a typo in my commit (verical -> vertical)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants