Support alignment for reader conditionals #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried this code at work for a week, has given me no issue. Let me know if there's any point of improvement! |
vemv
force-pushed
the
align-reader-conditionals
branch
from
e9ce48f to
293d739
Compare
bbatsov
reviewed
Aug 24, 2018
clojure-mode.el
Outdated
| (not (eq (char-before (1- point)) ?\#))) | ||
| ;; Are we in a reader conditional? | ||
| (and clojure-align-reader-conditionals | ||
| (or (and (eq (char-before (- point 2)) ?\#) |
There was a problem hiding this comment.
Can't we use some string or regular expressions instead? Seems odd to be looking for a sequence of characters like this.
bbatsov
reviewed
Aug 24, 2018
clojure-mode.el
Outdated
| clojure-align-cond-forms) | ||
| 'symbols)) | ||
| (concat (when clojure-align-reader-conditionals | ||
| "#\\?@(\\|#\\?(\\|") |
There was a problem hiding this comment.
I'd probably put those in some var.
|
Apart from my small remarks the changes look good. Also - don't forget to file a PR for the other alignment change we discussed recently. |
vemv
force-pushed
the
align-reader-conditionals
branch
from
293d739 to
28bf6fc
Compare
vemv
force-pushed
the
align-reader-conditionals
branch
from
28bf6fc to
8ed99ba
Compare
vemv
force-pushed
the
align-reader-conditionals
branch
from
136f172 to
4eeb5b3
Compare
|
Alright, thanks for the review! Ready again. |
|
Thanks! |
|
🙌 I'll work on the other stuff that you mentioned earlier today, during the week. |
|
Great!
On Mon, 27 Aug 2018 at 20:28, vemv ***@***.***> wrote:
🙌 I'll work on the other stuff that you mentioned earlier today, during
the week.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#486 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGVytwnWwccj-SgbC2zYLYIymsAbv6wks5uVDo-gaJpZM4WLKYz>
.
--
Best Regards,
Bozhidar Batsov
http://www.batsov.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483.