Fix namespace font locking

[Bost]

• The commits are consistent with our [contribution guidelines][1]

• You've added tests (if possible) to cover your change(s). Indentation & font-lock tests are extremely important!

• All tests are passing (make test)

• Using cask for testing is a pain :-(

1. Cask installation doesn't work from behind a proxy
2. Being behind or a proxy or not - in both cases I get:

$ make test
make: *** No rule to make target '/home/bost/dev/clojure-mode/.cask/25.3/elpa', needed by 'test'.  Stop.

However M-x spacemacs/ert-run-tests-buffer shows no new errors (on top of those 8 existing already)

• The new code is not generating bytecode or M-x checkdoc warnings
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)
• I fixed a bug. No readme change is needed.

[bbatsov]

I'd actually also add new unit tests verifying the validity of your changes.

[bbatsov]

You can also mention here the GH issue you've fixed. This sentence should end with a ..

[Bost]

I did the fix out of pure excitement of having found "a pristine spot on a wall I can spray my tag on". Ok seriously there is no GH issue for my PR. Although the #280 seems to be closely related.

[bbatsov]

However M-x spacemacs/ert-run-tests-buffer shows no new errors (on top of those 8 existing already)

Hmm, that's odd. There shouldn't be any failing tests (there were certainly none last time I checked). Unfortunately the TravisCI setup seems to have been magically broken and I don't have time to look into this myself at this time.

[Bost]

Hmm, that's odd. There shouldn't be any failing tests (there were certainly none last time I checked).

It seems like something's messed up somewhere also on my side. M-x spacemacs/ert-run-tests-buffer on current master 35f5d71 now gives me only 4 errors. Not 8 as I reported. And my changes introduced 4 new errors on top of the 4 from the master. Merde :-( Could you please run the test on your machine? Thx.

Here the M-x spacemacs/ert-run-tests-buffer of test/clojure-mode-font-lock-test.el on current master 35f5d71:

Selector: (satisfies (lambda (test) (eq cbuf (spacemacs//find-ert-test-buffer test))))
Passed:  30
Failed:  4 (4 unexpected)
Skipped: 0
Total:   34/34

Started at:   2017-10-13 01:07:49+0200
Finished.
Finished at:  2017-10-13 01:07:52+0200

F.F.......F.............F.........

F clojure-mode-syntax-table/characters
    (ert-test-failed
     ((should
       (eq
        (clojure-test-face-at 1 2 "\\1")
        'clojure-character-face))
      :form
      (eq various-faces clojure-character-face)
      :value nil))

F clojure-mode-syntax-table/comment-macros
    (ert-test-failed
     ((should
       (equal
        (clojure-test-face-at 5 41 "#_ 
;; some crap
 (lala 0101
 lao

 0 0i)")
        'font-lock-comment-face))
      :form
      (equal various-faces font-lock-comment-face)
      :value nil :explanation
      (different-atoms various-faces font-lock-comment-face)))

F clojure-mode-syntax-table/fn
    (ert-test-failed
     ((should
       (eq
        (clojure-test-face-at 2 3)
        'font-lock-keyword-face))
      :form
      (eq t font-lock-keyword-face)
      :value nil))

F clojure-mode-syntax-table/ns-macro
    (ert-test-failed
     ((should
       (eq
        (clojure-test-face-at 1 10 "[ns name]")
        nil))
      :form
      (eq various-faces nil)
      :value nil))

[Bost]

I'm closing this PR. I'm gonna send you a new PR without regressions.