[Fix #429] Last occurrence sometimes not replaced for move-to-let
#430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Apr 7, 2017
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Bugs fixed | |||
|
|
|||
| * [#429](https://github.com/clojure-emacs/clojure-mode/issues/429): Fix last occurrence of expression sometimes is not replaced when using `move-to-let`. | |||
There was a problem hiding this comment.
This sentence sounds a bit strange to me. :-) Perhaps "Fix a bug causing the last..."?
In case * there are more than one occurrences of expression * and move to let is not initiated from the last occurrence * and actual bound name is longer than the expression being moved to let the last expression won't be replaced. Fix: end of `let` expression is not cached before calling `clojure--replace-sexps-with-binding`.
slipset
pushed a commit
to slipset/clojure-mode
that referenced
this pull request
Nov 1, 2017
…ove-to-let` (clojure-emacs#430) In the following case: * there are more than one occurrences of an expression * and `move-to-let` is not initiated from the last occurrence * and the actual bound name is longer than the expression being moved to `let` the last expression won't be replaced. The solution: the end of the `let` expression is not cached before calling `clojure--replace-sexps-with-binding`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
the last expression won't be replaced.
Fix: end of
letexpression is not cached before callingclojure--replace-sexps-with-binding.Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
make test)M-x checkdocwarningsThanks!