Fix for error in clojure-expected-ns.
#313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (let* ((relative (clojure-project-relative-path | ||
| (or path (file-truename (buffer-file-name))))) | ||
| (let* ((path (or path (file-truename (buffer-file-name)))) | ||
| (relative (clojure-project-relative-path path)) | ||
| (sans-file-type (substring relative 0 (- (length (file-name-extension path t))))) |
There was a problem hiding this comment.
If you can't spot the problem, @bbatsov, path will be nil on this line when the function is called without any arguments.
|
Thanks for fixing this. Testing this function was surprisingly hard due to the myriad calls against some current state in emacs. Ironically this bug was introduced when I refactored the function to make it easier to test :/ |
| (should (string= (clojure-expected-ns clj-file-path) clj-file-ns))))) | ||
| (should (string= (clojure-expected-ns clj-file-path) clj-file-ns)))) | ||
|
|
||
| (ert-deftest expected-ns-2 () |
There was a problem hiding this comment.
You can use a descriptive name for the test. :-)
|
Drop the |
When call `clojure-expected-ns` function without arguments, error occured.
|
I was changed a commit message and test name. |
bbatsov
added a commit
that referenced
this pull request
Aug 1, 2015
Fix for error in `clojure-expected-ns`.
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When call
clojure-expected-nsfunction without arguments,error occurred.
related commit: 4be6843