Skip to content

clojure-mode.el (clojure-fill-paragraph): Tiny fix #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2014
Merged

clojure-mode.el (clojure-fill-paragraph): Tiny fix #243

merged 3 commits into from
Jul 26, 2014

Conversation

bzg
Copy link
Contributor

@bzg bzg commented Jul 26, 2014

  • clojure-mode.el (clojure-fill-paragraph): Add a docstring.
    Fix filling of functions' parameters.

* clojure-mode.el (clojure-fill-paragraph): Add a docstring.
Fix filling of functions' parameters.
@bbatsov
Copy link
Member

bbatsov commented Jul 26, 2014

Could you also add a few ert tests for fill-paragraph? I want us to gradually turn clojure-mode into a properly tested project with solid code coverage.

@bbatsov
Copy link
Member

bbatsov commented Jul 26, 2014

You can use ruby-mode's tests as a source of inspiration http://git.savannah.gnu.org/cgit/emacs.git/tree/test/automated/ruby-mode-tests.el?h=emacs-24

Bastien Guerry added 2 commits July 26, 2014 15:50
* clojure-mode.el (clojure-font-lock-keywords)
(clojure-mode-font-lock-regexp-groups, define-clojure-indent):
Cosmetic fixes.
* clojure-mode.el (clojure-mode): Bind `indent-line-function' to
the new function `clojure-indent-line'.
(clojure-indent-line): New function to let TAB indent correctly in
docstrings.
@bzg
Copy link
Contributor Author

bzg commented Jul 26, 2014

I won't have time for adding tests, my plate is quite full, sorry.

@bbatsov
Copy link
Member

bbatsov commented Jul 26, 2014

I won't have time for adding tests, my plate is quite full, sorry.

No problem.

bbatsov added a commit that referenced this pull request Jul 26, 2014
clojure-mode.el (clojure-fill-paragraph): Tiny fix
@bbatsov bbatsov merged commit 39f066d into clojure-emacs:master Jul 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants