Skip to content

Support picking question via name #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2023
Merged

Conversation

gotlougit
Copy link
Contributor

This PR adds a new flag to leetcode pick which allows users to select a question based on the question name. The question name has to be exactly the same, but given how it is sometimes easier to remember the question name rather than question number in Leetcode, this will still help in ease of use.

Eg. leetcode pick --name "Two Sum" gets the Two Sum problem from LeetCode. If no name is present, it defaults to finding by ID as before.

The rest of the subcommands are exactly the same since it is presumed that the user can just look at the question number from leetcode pick anyway.

README was also changed to reflect this new command type.

@clearloop
Copy link
Owner

clearloop commented Jun 25, 2023

hey @gotlougit! would you mind merging master and resolving the conflicts? imo the current PR is enough for merging!

@gotlougit
Copy link
Contributor Author

I noticed there was a different error while running cargo check, it seems unrelated to this PR.

@clearloop clearloop merged commit d26cb4e into clearloop:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants