Skip to content

Make the packaging shell file work on osx #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

zafarella
Copy link

Description of changes:
Make the packaging work on osx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marcomagdy
Copy link
Contributor

But why?
I intentionally ignored making it work on MacOS. Otherwise, it will package successfully only to crash when you deploy it.
Lambda runs on Linux. The binaries you package on MacOS will never work.
Is there a use case that I'm missing?

@zafarella
Copy link
Author

this is why working at night is not good..)
So we don't have linux as daily using machine, mbe add cross compilation or may be add container?
My point is to have less setup and get it working on osx

@marcomagdy
Copy link
Contributor

I have a couple of docker images that I use for CI.

See if you can improve on those to streamline the process?!
Cross-compilation can be tricky, and there's already a learning curve to C++ on Lambda. I'd rather stay away from that.
That being said, I don't want to shut the door on that option. It might a productivity boon if it's done right.

So, I guess my answer is, see what you can come up with :)
I'm happy to review it.

@daleobrien
Copy link

daleobrien commented May 3, 2019

You might find https://github.com/daleobrien/aws-lambda-cpp-hello-world could help. It will build a "hello world" lambda function on OSX using only docker and produce a zip file you can then use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants