-
Notifications
You must be signed in to change notification settings - Fork 1.2k
change: Add image configs and region config for TPE (ap-east-2) #5167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -8,6 +8,7 @@ | |||
"versions": { | |||
"0.29.0": { | |||
"registries": { | |||
"ap-east-2": "975050140332", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure neuronx is regionalized here? We had this issue before where we are adding regions that don't contain the images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed in the regionalizer, otherwise this will block new regions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neuronx has a specific regionalization process that we own. We own the region list that neuronx will be regionalized to. If that did not update, we should not update this as customers would expect the image to be in that region when it isn't
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.