valid the bootstraps before passing to NewBootstrapSingleCmd #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchengru
force-pushed
the
lookstrappath
branch
from
9a23188 to
e45a909
Compare
valerena
reviewed
Aug 30, 2021
cmd/aws-lambda-rie/main.go
Outdated
| fmt.Sprintf("%s/bootstrap", currentWorkingDir), | ||
| optBootstrap, | ||
| runtimeBootstrap, | ||
| } | ||
|
|
||
| // set default value to /var/task/bootstrap, but switch to the other options if it doesn't exist | ||
| bootstrapLookupCmd = []string{bootstrapCmdCandidates[0]} |
There was a problem hiding this comment.
Probably minor, but it looks somewhat weird to set this default value, but then changing the variable to potentially this same value again if it passes the "if" below.
There was a problem hiding this comment.
Thanks, I have refactored this part to make it clearer.
valerena
approved these changes
Aug 30, 2021
wchengru
added a commit
to wchengru/aws-sam-cli
that referenced
this pull request
Aug 30, 2021
This was referenced Aug 30, 2021
jfuss
added a commit
to aws/aws-sam-cli
that referenced
this pull request
Sep 9, 2021
* New release of RIE: 1.1 * Update RIE 1.1 with PR aws/aws-lambda-runtime-interface-emulator#45 * add integrate test case to run simple verification on sam local invoke * update appveyor config to pull test image only without canary * fix a syntax error * remove unused print log * keep the tests in canary to avoid docker pull throttling Co-authored-by: Renato Valenzuela <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Mathieu Grandis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This PR is to fix an issue in SAM CLI running
sam local invokewith errorlevel=error msg="Init failed" InvokeID= error="fork/exec /var/task/bootstrap: no such file or directory"We validate the existence of the three bootstrap file options at first.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.