fix: Add a fake arn to Context #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
approved these changes
Feb 25, 2021
| Payload: bodyBytes, | ||
| CorrelationID: "invokeCorrelationID", | ||
| ID: uuid.New().String(), | ||
| InvokedFunctionArn: fmt.Sprintf("arn:aws:lambda:us-east-1:012345678912:function:%s", GetenvWithDefault("AWS_LAMBDA_FUNCTION_NAME", "test_function")), |
There was a problem hiding this comment.
nit: show we move the defaults such as test_function, default memory of 3008 etc to a constants.go ?
There was a problem hiding this comment.
Not sure if that could be an issue or not, but are we sure this account number doesn't exist?
Do we have example/dummy account numbers for this?
There was a problem hiding this comment.
@mgrandis This is typically the account used as "fake" from what I have seen. I have no idea if it is a real account but we need something that looks like an account id. Do you have a better suggestion?
@sriram-mv Given this is likely not to change much at all. I am going to leave as is for now. Will keep an eye on this and refactor if this comes up again.
mgrandis
reviewed
Feb 25, 2021
mgrandis
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#11
Description of changes:
Adds support for
lambda-runtime-invoked-function-arnheader.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.