test(common,logger,metrics): run e2e tests for metrics in both Node runtimes

[ijemmy]

Description of your changes

Changes in this PR.

• refactor metrics e2e tests to make stack and resource name unique (so that they can be run in parallel)
• refactor metrics e2e tests to be consistent with logger and move common code to commons
• run e2e tests on both Node12 and Node14 runtimes

How to verify this change

Run npm run lerna-test:e2e at the root.

Every test should pass and metrics tests should be on both node14 and node12

Related issues, RFCs

#497

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

• My changes meet the tenets criteria
• I have performed a self-review of my own code
• I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding changes to the examples
• My changes generate no new warnings
• The code coverage hasn't decreased
• I have added tests that prove my change is effective and works
• New and existing unit tests pass locally and in Github Actions
• Any dependent changes have been merged and published in downstream module
• The PR title follows the conventional commit semantics

Breaking change checklist

• I have documented the migration process
• I have added, implemented necessary warnings (if it can live side by side)

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[dreamorosi]

Thanks a lot for the PR, I like the direction you're giving to the integration tests. It'll make them much easier to maintain moving forward.

My only concern relates to exporting the e2e utilities in the commons package. This package is depended and bundled by all the other utilities and as such it will be included in the deployment package of each function that uses Powertools.

While I think there's definitely value in providing test utilities (see #445), I don't know if it should be in commons and in general, if it's code that should be deployed in Lambda.

What's your take?

[ijemmy]

Thanks a lot for the PR, I like the direction you're giving to the integration tests. It'll make them much easier to maintain moving forward.

My only concern relates to exporting the e2e utilities in the commons package. This package is depended and bundled by all the other utilities and as such it will be included in the deployment package of each function that uses Powertools.

While I think there's definitely value in providing test utilities (see #445), I don't know if it should be in commons and in general, if it's code that should be deployed in Lambda.

What's your take?

I totally agree with you. We'll unnecessarily increase package size. I'll change this.
Found that I modify quite a few files with #676 . I'll wait until that one is merge first, resolve conflict, and change this.

I've remove the module from the --group param.