Skip to content

chore(maintenance): adjust type exports in parameters & idempotency #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR modifies some of the type exports for the Parameters and Idempotency packages which, as reported in the linked issue, were incorrect.

The misconfiguration was not causing any runtime issue because it affected only exports that are ever used only during development (types are not used at runtime and in most cases are removed from the code altogether).

The PR aligns the type exports in the two packages to the ones found in all the other packages.

Related issues, RFCs

Issue number: #2284

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Mar 27, 2024
@dreamorosi dreamorosi requested a review from a team March 27, 2024 11:55
@dreamorosi dreamorosi requested a review from a team as a code owner March 27, 2024 11:55
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Mar 27, 2024
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Mar 27, 2024
@dreamorosi dreamorosi requested a review from sthulb March 27, 2024 11:55
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sthulb sthulb merged commit 69f01a7 into main Mar 27, 2024
@sthulb sthulb deleted the 2284-bug-incorrect-packagejson-exports branch March 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: type exports in Parameters & Idempotency pkgs are incorrect
2 participants