chore(ci): add versioning workflow for pre-release #2006
Merged
+287
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
reviewed
Feb 2, 2024
dreamorosi
reviewed
Feb 2, 2024
dreamorosi
reviewed
Feb 2, 2024
dreamorosi
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Thank you for working on this. Looks great and I have tested it in a fork.
Would like to hear from @sthulb if we could move this action (aka only what's under .github/actions/create-pr) under the dedicated actions repo we have in the org.
This action is an almost exact copy of the one here from the Python repo. The changes we made here should be able to be refactored so that they're parameters/inputs of the action.
This way we can have a single place & maintain only once rather than have the same / slightly similar action in two projects.
sthulb
reviewed
Feb 5, 2024
|
dreamorosi
approved these changes
Feb 6, 2024
15 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a workflow to run versioning before a release, which solves two issues. 1/
lerna versiondoes not push the commit back tomain, 2/ we can review version and changelog changes before the release, avoiding accidentally wrong version bumps based on conventional commits.While we previously had a tag during versioning, I suggest keeping the tag after a successful package publish step in the release workflow.
Related issues, RFCs
Issue number: #1799
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.