Skip to content

chore(ci): fix repo references #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024
Merged

chore(ci): fix repo references #2001

merged 1 commit into from
Feb 1, 2024

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR fixes two more issues with the CI workflows: one related to origin checks, and the other with a broken link.

For some workflows that have access to privileged environments we use if statements to check that the workflow is running in the correct repository. The workflow used to publish the docs was doing this check but incorrectly using the Python repo name, this was the result of a wrong copy/paste.

Additionally, the URL for the acknowledgement section in the pull request template was incorrect. This PR updates the URL to the correct location.

Related issues, RFCs

Issue number: #1799

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team February 1, 2024 11:28
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Feb 1, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Feb 1, 2024
@dreamorosi dreamorosi self-assigned this Feb 1, 2024
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dreamorosi dreamorosi requested a review from am29d February 1, 2024 11:29
@dreamorosi
Copy link
Contributor Author

This should hopefully be the last PR related to docs workflow configs for a while.

Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@am29d am29d merged commit cde09e5 into main Feb 1, 2024
@am29d am29d deleted the chore/fix_docs_workflow branch February 1, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants