Skip to content

chore(ci): Permissions work #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore(ci): Permissions work #1804

wants to merge 2 commits into from

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Nov 29, 2023

Description of your changes

This PR amends some of the permission changes made in a previous PR (#1801) in an attempt to fix them.

Related issues, RFCs

Issue number: fixes #1799

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sthulb sthulb requested a review from a team November 29, 2023 08:27
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Nov 29, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Nov 29, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

dreamorosi

This comment was marked as outdated.

@dreamorosi dreamorosi self-requested a review November 29, 2023 22:49
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current changes look good, but while you're at it could you please fix these other issues that have popped up from previous changes.

Check some failed runs here:

@sthulb sthulb closed this Nov 30, 2023
@sthulb sthulb deleted the permissions-fixes branch November 30, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Improve security posture by addressing OpenSSF results
2 participants