fix: Add upload artifact to on-pull-request to save PR number for later auto-merge #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging fix/dependabot-auto-merge into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Also apologies for the noise, testing these workflows locally is tricky. |
alan-churley
approved these changes
Aug 13, 2021
bahrmichael
approved these changes
Sep 15, 2021
|
Closing this PR & deleting branch in favor of projen based one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
PR #169 introduced a workflow to auto-merge PRs from Dependabot which didn't work. The new workflow depended on the existence of an artefact created & saved from the previous workflow.
This is the recommended way to share data between workflows/jobs and uses a mechanism of upload & download artefact files between different workflows/jobs. In the previous PR I introduced the download part but since there was no upload, and the workflow depended on the existence of an artefact to find the PR number, the
auto-mergejob failed.This PR introduces a new job/step in the
on-pull-requestworkflow that should be executed only when the actor isdependabotand that should create a file with the PR number and upload it as an artefact. This artefact would then be used by theauto-mergeworkflow to merge.How to verify this change
If the change is effective, re-running the
on-pull-requestworkflow for an existing PR opened bydependabotshould cause the PR to be merged. Same applies to a newdependabotPR.Related issues, RFCs
#169
#126
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.