chore(logger): extract logger creation into protected method #1646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces a minor internal change into the Logger class that, in its current implementation, can help customers who want to customize the utility by extending/subclassing the Logger class.
Prior to this PR when creating a new child logger, the creation of a new Logger instance was inline inside the
createChild
method. Customers wanting to extend the Logger by creating their own subclass were having a difficult time doing so because the child loggers would be creating using the original Logger class.By extracting that logic into its own
createLogger
protected method customers can override the method and instantiate their own custom logger when creating a child.Related issues, RFCs
Issue number: #1307
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.