Skip to content

docs(parameters): add parameters examples cdk and sam #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 25, 2023
Merged

docs(parameters): add parameters examples cdk and sam #1622

merged 12 commits into from
Jul 25, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jul 21, 2023

Description of your changes

This PR adds parameters to the example project in CDK and SAM. I have removed 3rd party HTTP calls to httpbin, because they often timed out. Instead, we now have our own API that returns a random UUID. The example application uses parameters to store the API GW URL to the new API.

Related issues, RFCs

Issue number: closes #1037

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team July 21, 2023 13:07
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation dependencies Changes that touch dependencies, e.g. Dependabot, etc. labels Jul 21, 2023
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 21, 2023
@am29d am29d added the do-not-merge This item should not be merged label Jul 21, 2023
@am29d
Copy link
Contributor Author

am29d commented Jul 21, 2023

E2E run is green https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/5622701585

@am29d am29d requested review from dreamorosi and removed request for a team July 24, 2023 10:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.9% 0.9% Duplication

@am29d am29d requested a review from dreamorosi July 24, 2023 15:15
@am29d am29d removed the do-not-merge This item should not be merged label Jul 24, 2023
@dreamorosi dreamorosi merged commit 02cd84b into main Jul 25, 2023
@dreamorosi dreamorosi deleted the 1037-add-parameters-examples-cdk-sam branch July 25, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@am29d am29d

Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation size/L PRs between 100-499 LOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: add utility examples
2 participants
@am29d @dreamorosi