-
Notifications
You must be signed in to change notification settings - Fork 155
chore(maintenance): add powertools to user-agent in SDK clients #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dreamorosi
merged 17 commits into
aws-powertools:main
from
am29d:1533-user-agent-in-aws-sdk-clients
Jul 3, 2023
Merged
chore(maintenance): add powertools to user-agent in SDK clients #1567
dreamorosi
merged 17 commits into
aws-powertools:main
from
am29d:1533-user-agent-in-aws-sdk-clients
Jul 3, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
reviewed
Jun 29, 2023
dreamorosi
reviewed
Jun 29, 2023
dreamorosi
reviewed
Jun 29, 2023
dreamorosi
reviewed
Jun 29, 2023
dreamorosi
reviewed
Jun 29, 2023
|
dreamorosi
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
I have run the integration tests on this branch and they are passing.
}, | ||
}; | ||
|
||
describe('Given a client of instance: ', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean, I like it
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commons
This item relates to the Commons Utility
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
idempotency
This item relates to the Idempotency Utility
size/L
PRs between 100-499 LOC
tests
PRs that add or change tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In this PR we introduce our custom middleware that can be added to any middleware stack of AWS SDK v3 clients. We decided to use middleware instead of
customUserAgent
options, because we might get SDK client from the user. Becauseconfig
field of the client is readonly, we can't add change it, after the client has been initialised.Any feature using an SDK client can call like this:
this will modify the
user-agent
field by appendingPT/my-feature/1.10.0 PTEnv/NA
at the end of the value.I was about to add the new functionality to idempotency, but we will do it in a separate PR. Meanwhile, I have removed the singleton for the client in the
DynamoDBPersistenceLayer.ts
, similar how we use it parameters utility.Related issues, RFCs
Issue number: closes #1533
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.