-
Notifications
You must be signed in to change notification settings - Fork 155
docs(parameters): main docs for the utility #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e97af68
docs: added main section, SSMProvider, transform, and config
dreamorosi 697a4ba
chore: added missing new in front of constructor
dreamorosi 3d5ee6c
docs: added SecretsProvider sections
dreamorosi 42f2bc0
docs: fixes
dreamorosi 537b467
docs: added DynamoDBProvider
dreamorosi d84dbe5
docs: completed first version of docs
dreamorosi 87dd2bb
docs: extract code snippets
dreamorosi a8ee8d1
docs: review comments
dreamorosi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
const parametersProvider = new SSMProvider(); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single parameter | ||
const parameter = await parametersProvider.get('/my/parameter', { maxAge: 60 }); // 1 minute | ||
console.log(parameter); | ||
|
||
// Retrieve multiple parameters from a path prefix | ||
const parameters = await parametersProvider.getMultiple('/my/path/prefix', { maxAge: 120 }); // 2 minutes | ||
for (const [ key, value ] of Object.entries(parameters || {})) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { AppConfigProvider } from '@aws-lambda-powertools/parameters/appconfig'; | ||
import type { AppConfigDataClientConfig } from '@aws-sdk/client-appconfigdata'; | ||
|
||
const clientConfig: AppConfigDataClientConfig = { region: 'us-east-1' }; | ||
const configsProvider = new AppConfigProvider({ | ||
application: 'my-app', | ||
environment: 'my-env', | ||
clientConfig, | ||
}); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a config | ||
const config = await configsProvider.get('my-config'); | ||
console.log(config); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { AppConfigProvider } from '@aws-lambda-powertools/parameters/appconfig'; | ||
import { AppConfigDataClient } from '@aws-sdk/client-appconfigdata'; | ||
|
||
// construct your clients with any custom configuration | ||
const appConfigClient = new AppConfigDataClient({ region: 'us-east-1' }); | ||
// pass the client to the provider | ||
const configsProvider = new AppConfigProvider({ awsSdkV3Client: appConfigClient }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
const config = await configsProvider.get('my-config'); | ||
console.log(config); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm'; | ||
import type { SSMClientConfig } from '@aws-sdk/client-ssm'; | ||
|
||
const clientConfig: SSMClientConfig = { region: 'us-east-1' }; | ||
const parametersProvider = new SSMProvider({ clientConfig }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single parameter | ||
const value = await parametersProvider.get('/my/parameter'); | ||
console.log(value); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { DynamoDBProvider } from '@aws-lambda-powertools/parameters/dynamodb'; | ||
|
||
const dynamoDBProvider = new DynamoDBProvider({ tableName: 'my-table' }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a value from DynamoDB | ||
const value = await dynamoDBProvider.get('my-parameter'); | ||
console.log(value); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { DynamoDBProvider } from '@aws-lambda-powertools/parameters/dynamodb'; | ||
import { DynamoDBClient } from '@aws-sdk/client-dynamodb'; | ||
|
||
// construct your clients with any custom configuration | ||
const dynamoDBClient = new DynamoDBClient({ region: 'us-east-1' }); | ||
// pass the client to the provider | ||
const valuesProvider = new DynamoDBProvider({ awsSdkV3Client: dynamoDBClient }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single value | ||
const value = await valuesProvider.get('my-value'); | ||
console.log(value); | ||
}; |
13 changes: 13 additions & 0 deletions
13
docs/snippets/parameters/dynamoDBProviderCustomizeTable.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { DynamoDBProvider } from '@aws-lambda-powertools/parameters/dynamodb'; | ||
|
||
const dynamoDBProvider = new DynamoDBProvider({ | ||
tableName:'my-table', | ||
keyAttr:'key', | ||
sortAttr:'sort', | ||
valueAttr:'val' | ||
}); | ||
|
||
export const handler = async (): Promise<void> => { | ||
const value = await dynamoDBProvider.get('my-parameter'); | ||
console.log(value); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { DynamoDBProvider } from '@aws-lambda-powertools/parameters/dynamodb'; | ||
|
||
const dynamoDBProvider = new DynamoDBProvider({ | ||
tableName: 'my-table', | ||
clientConfig: { | ||
endpoint: 'http://localhost:8000' | ||
}, | ||
}); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a value from DynamoDB | ||
const value = await dynamoDBProvider.get('my-parameter'); | ||
console.log(value); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { DynamoDBProvider } from '@aws-lambda-powertools/parameters/dynamodb'; | ||
|
||
const dynamoDBProvider = new DynamoDBProvider({ tableName: 'my-table' }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
/** | ||
* Retrieve multiple values by performing a Query on the DynamoDB table. | ||
* This returns a dict with the sort key attribute as dict key. | ||
*/ | ||
const values = await dynamoDBProvider.getMultiple('my-hash-key'); | ||
for (const [ key, value ] of Object.entries(values || {})) { | ||
// key: param-a | ||
// value: my-value-a | ||
console.log(`${key}: ${value}`); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { getParameter } from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single parameter | ||
const parameter = await getParameter('/my/parameter', { forceFetch: true }); | ||
console.log(parameter); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { getAppConfig } from '@aws-lambda-powertools/parameters/appconfig'; | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a configuration, latest version | ||
const config = await getAppConfig('my-configuration', { | ||
environment: 'my-env', | ||
application: 'my-app' | ||
}); | ||
console.log(config); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { getParameter } from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single parameter | ||
const parameter = await getParameter('/my/parameter'); | ||
console.log(parameter); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { getParameters } from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
export const handler = async (): Promise<void> => { | ||
/** | ||
* Retrieve multiple parameters from a path prefix recursively. | ||
* This returns an object with the parameter name as key | ||
*/ | ||
const parameters = await getParameters('/my/path/prefix'); | ||
for (const [ key, value ] of Object.entries(parameters || {})) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { getParametersByName } from '@aws-lambda-powertools/parameters/ssm'; | ||
import type { | ||
SSMGetParametersByNameOptionsInterface | ||
} from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
const props: Record<string, SSMGetParametersByNameOptionsInterface> = { | ||
'/develop/service/commons/telemetry/config': { maxAge: 300, transform: 'json' }, | ||
'/no_cache_param': { maxAge: 0 }, | ||
'/develop/service/payment/api/capture/url': {}, // When empty or undefined, it uses default values | ||
}; | ||
|
||
export const handler = async (): Promise<void> => { | ||
// This returns an object with the parameter name as key | ||
const parameters = await getParametersByName(props, { maxAge: 60 }); | ||
for (const [ key, value ] of Object.entries(parameters)) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
}; |
25 changes: 25 additions & 0 deletions
25
docs/snippets/parameters/getParametersByNameGracefulErrorHandling.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { getParametersByName } from '@aws-lambda-powertools/parameters/ssm'; | ||
import type { | ||
SSMGetParametersByNameOptionsInterface | ||
} from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
const props: Record<string, SSMGetParametersByNameOptionsInterface> = { | ||
'/develop/service/commons/telemetry/config': { maxAge: 300, transform: 'json' }, | ||
'/this/param/does/not/exist': {}, // <- Example of non-existent parameter | ||
}; | ||
|
||
export const handler = async (): Promise<void> => { | ||
const { | ||
_errors: errors, | ||
...parameters | ||
} = await getParametersByName(props, { throwOnError: false }); | ||
|
||
// Handle gracefully, since `/this/param/does/not/exist` will only be available in `_errors` | ||
if (errors && errors.length) { | ||
console.error(`Unable to retrieve parameters: ${errors.join(',')}`); | ||
} | ||
|
||
for (const [ key, value ] of Object.entries(parameters)) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { getSecret } from '@aws-lambda-powertools/parameters/secrets'; | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single secret | ||
const secret = await getSecret('my-secret'); | ||
console.log(secret); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { SecretsProvider } from '@aws-lambda-powertools/parameters/secrets'; | ||
import type { GetSecretValueCommandInput } from '@aws-sdk/client-secrets-manager'; | ||
|
||
const secretsProvider = new SecretsProvider(); | ||
|
||
export const handler = async (): Promise<void> => { | ||
const sdkOptions: Partial<GetSecretValueCommandInput> = { | ||
VersionId: 'e62ec170-6b01-48c7-94f3-d7497851a8d2' | ||
}; | ||
/** | ||
* The 'VersionId' argument will be passed to the underlying | ||
* `GetSecretValueCommand` call. | ||
*/ | ||
const secret = await secretsProvider.get('my-secret', { sdkOptions }); | ||
console.log(secret); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { SecretsProvider } from '@aws-lambda-powertools/parameters/secrets'; | ||
import type { SecretsManagerClientConfig } from '@aws-sdk/client-secretsmanager'; | ||
|
||
const clientConfig: SecretsManagerClientConfig = { region: 'us-east-1' }; | ||
const secretsProvider = new SecretsProvider({ clientConfig }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single secret | ||
const secret = await secretsProvider.get('my-secret'); | ||
console.log(secret); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { SecretsProvider } from '@aws-lambda-powertools/parameters/secrets'; | ||
import { SecretsManagerClient } from '@aws-sdk/client-secrets-manager'; | ||
|
||
// construct your clients with any custom configuration | ||
const secretsManagerClient = new SecretsManagerClient({ region: 'us-east-1' }); | ||
// pass the client to the provider | ||
const secretsProvider = new SecretsProvider({ awsSdkV3Client: secretsManagerClient }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single secret | ||
const secret = await secretsProvider.get('my-secret'); | ||
console.log(secret); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm'; | ||
import type { SSMClientConfig } from '@aws-sdk/client-ssm'; | ||
|
||
const clientConfig: SSMClientConfig = { region: 'us-east-1' }; | ||
const parametersProvider = new SSMProvider({ clientConfig }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single parameter | ||
const parameter = await parametersProvider.get('/my/parameter'); | ||
console.log(parameter); | ||
|
||
// Retrieve multiple parameters from a path prefix | ||
const parameters = await parametersProvider.getMultiple('/my/path/prefix'); | ||
for (const [ key, value ] of Object.entries(parameters || {})) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm'; | ||
import { SSMClient } from '@aws-sdk/client-ssm'; | ||
|
||
// construct your clients with any custom configuration | ||
const ssmClient = new SSMClient({ region: 'us-east-1' }); | ||
// pass the client to the provider | ||
const parametersProvider = new SSMProvider({ awsSdkV3Client: ssmClient }); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Retrieve a single parameter | ||
const parameter = await parametersProvider.get('/my/parameter'); | ||
console.log(parameter); | ||
}; |
13 changes: 13 additions & 0 deletions
13
docs/snippets/parameters/ssmProviderDecryptAndRecursive.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
const parametersProvider = new SSMProvider(); | ||
|
||
export const handler = async (): Promise<void> => { | ||
const decryptedValue = await parametersProvider.get('/my/encrypted/parameter', { decrypt: true }); | ||
console.log(decryptedValue); | ||
|
||
const noRecursiveValues = await parametersProvider.getMultiple('/my/path/prefix', { recursive: false }); | ||
for (const [ key, value ] of Object.entries(noRecursiveValues || {})) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import { getParameter } from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
export const handler = async (): Promise<void> => { | ||
const valueFromJson = await getParameter('/my/json/parameter', { transform: 'json' }); | ||
console.log(valueFromJson); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
const parametersProvider = new SSMProvider(); | ||
|
||
export const handler = async (): Promise<void> => { | ||
const values = await parametersProvider.getMultiple('/param', { transform: 'auto' }); | ||
for (const [ key, value ] of Object.entries(values || {})) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm'; | ||
|
||
const parametersProvider = new SSMProvider(); | ||
|
||
export const handler = async (): Promise<void> => { | ||
/** | ||
* This will display: | ||
* /param/a: [some value] | ||
* /param/b: [some value] | ||
* /param/c: undefined | ||
*/ | ||
const parameters = await parametersProvider.getMultiple('/param', { transform: 'json' }); | ||
for (const [ key, value ] of Object.entries(parameters || {})) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
|
||
try { | ||
// This will throw a TransformParameterError | ||
const parameters2 = await parametersProvider.getMultiple('/param', { | ||
transform: 'json', | ||
throwOnTransformError: true | ||
}); | ||
for (const [ key, value ] of Object.entries(parameters2 || {})) { | ||
console.log(`${key}: ${value}`); | ||
} | ||
} catch (err) { | ||
console.error(err); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { SecretsProvider } from '@aws-lambda-powertools/parameters/secrets'; | ||
|
||
const secretsProvider = new SecretsProvider(); | ||
|
||
export const handler = async (): Promise<void> => { | ||
// Transform a JSON string | ||
const json = await secretsProvider.get('my-secret-json', { transform: 'json' }); | ||
console.log(json); | ||
|
||
// Transform a Base64 encoded string (e.g. binary) | ||
const binary = await secretsProvider.getMultiple('my-secret-binary', { transform: 'binary' }); | ||
console.log(binary); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix comment indentation